#141680: "incorrect score display"
В какво се състои този доклад?
Какво се случи? Моля изберете от списъка по-долу
Какво се случи? Моля изберете от списъка по-долу
Моля, проверете дали вече има доклад по същия въпрос
Ако отговорът е „да“, моля, гласувайте за този доклад. Отчетите с най-много гласове са дадени ПРИОРИТЕТ!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Подробно описание
-
• Моля поставете тук съобщението за грешка което виждате, ако има такова
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Моля обяснете, какво искахте да направите, какво направихте и какво се случи
• Какъв е вашия браузър?
opera
-
• Моля копирайте/поставете текстът показан на аглийски, вместо на Вашия език. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. Наличен ли е този текст в системата за превод? Ако да, бил ли е преведен за повече от 24 часа?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Какъв е вашия браузър?
opera
-
• Моля обяснете вашето придложение ясно и кратко така че да бъде възможно най-разбираемо.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Какъв е вашия браузър?
opera
-
• Какво е било показано на екрана, когато сте били блокирани (празен екран? Част от интерфейса на играта? Съобщение за грешка?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Какъв е вашия браузър?
opera
-
• Коя част от правилата не е била спазена от BGA адаптацията
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Нарушенията на правилата видими ли са при повторение на играта? Ако да, на кой ход се случват?
• Какъв е вашия браузър?
opera
-
• Какъв бе игровият ход, който се опитахте да извършите?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Какво се опитвате да направите, за да задействате тази игра?
-
• Какво се случи, когато се опитахте да направите това (съобщение за грешка, съобщение за статуса на играта, ...)?
• Какъв е вашия браузър?
opera
-
• В кой момент от играта се появи проблема (каква е била съответната инструкция в играта)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Какво се случи, когато се опитахте да извършите действието в играта (съобщение за грешка, съобщение за статуса на играта, ...)?
• Какъв е вашия браузър?
opera
-
• Моля опишете грешката при изобразяването If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Какъв е вашия браузър?
opera
-
• Моля копирайте/поставете текстът показан на аглийски, вместо на Вашия език. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. Наличен ли е този текст в системата за превод? Ако да, бил ли е преведен за повече от 24 часа?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Какъв е вашия браузър?
opera
-
• Моля обяснете вашето придложение ясно и кратко така че да бъде възможно най-разбираемо.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Какъв е вашия браузър?
opera
История на докладванията
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Добави нещо към този доклад
- Друга маса ID / Ход ID
- F5 реши ли проблема?
- Проблемът няколко пъти ли се е появил? Или всеки път? Или абсолютно случайно?
- If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
